Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COOP: Potential ambiguity in definition of sandboxing flag sets #5682

Closed
jugglinmike opened this issue Jun 26, 2020 · 1 comment · Fixed by #5686
Closed

COOP: Potential ambiguity in definition of sandboxing flag sets #5682

jugglinmike opened this issue Jun 26, 2020 · 1 comment · Fixed by #5686
Labels
topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header.

Comments

@jugglinmike
Copy link
Contributor

The patch introduced by gh-5334 mentions a property of a browsing context named "sandboxing flag set" four times. Three are references to the value (two in navigate and one in process a navigate fetch). The obtain a browsing context to use for a navigation response algorithm sets the property's value.

By my reading, that property has not been formally defined. A sandboxing flag set is a type, but (barring the new cases mentioned above) it only appears to be realized as a property using some qualifier:

Every top-level browsing context has a popup sandboxing flag set, [...]

Every iframe element has an iframe sandboxing flag set, [...]

Every Document has an active sandboxing flag set, [...]

Every resource that is obtained by the navigation algorithm has a forced sandboxing flag set, [...]

Since the "popup sandboxing flag set" already associates a "sandboxing flag set" with a browsing context, it first seemed like the new cases were just a typo. However, a browsing context also has a property named simply sandboxing flags, defined as follows:

After creation, the sandboxing flags for a browsing context browsing context are the result of determining the creation sandboxing flags given browsing context and browsing context's container.

It's unclear how the new "browsing context's sandboxing flag set" relates to "the sandboxing flags for a browsing context." They may be one in the same, though the definition of "sandboxing flags" suggests that the value isn't intended to be modified.

@camillelamy @annevk @domenic Does my confusion make sense? Have I missed something important?

@annevk annevk added the topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header. label Jun 26, 2020
@annevk
Copy link
Member

annevk commented Jun 26, 2020

Yeah, this was integrated incorrectly. It should talk about the slot on browsing contexts (i.e., sandboxing flags) and the place where we set we should use the popup sandboxing flag set similar to "the rules for choosing a browsing context".

jugglinmike added a commit to bocoup/html that referenced this issue Jun 26, 2020
Replace ambiguous references to a browsing context property named
"sandboxing flag set".

Closes whatwggh-5682.
domenic pushed a commit that referenced this issue Jul 10, 2020
Replaces ambiguous references to a browsing context property named
"sandboxing flag set".

Closes #5682.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 11, 2020
Replaces ambiguous references to a browsing context property named
"sandboxing flag set".

Closes whatwg#5682.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header.
Development

Successfully merging a pull request may close this issue.

2 participants