Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop-up blocker algorithm doesn't define behavior for touch #599

Closed
RByers opened this issue Feb 1, 2016 · 4 comments
Closed

pop-up blocker algorithm doesn't define behavior for touch #599

RByers opened this issue Feb 1, 2016 · 4 comments

Comments

@RByers
Copy link

RByers commented Feb 1, 2016

The allowed to show a pop-up definition lists a number of types of events, including mouseup and click. But doesn't define what the behavior should be for touch input, eg. inside of a touchend or pointerup listener.

Today chromium permits popup from within any touch event, but this has caused problems with pop-ups during a scroll. Safari appears to have a more complex algorithm where pop-ups can be opened from some touchend listeners (eg. corresponding to taps), but not others (eg. corresponding to scrolls). We're debating how we want to change the behavior in chromium here. Once we have data on what seems to work well, I'm happy to submit a PR to the spec for this.

If others have opinions on the constraints for this algorithm, please mention them here (or the above chromium bug).

@mikewest
Copy link
Member

mikewest commented Feb 1, 2016

I'd love for @jeisinger to have time to look at this in more detail, as that algorithm is fairly naïve, and doesn't really match what browsers are doing. Touch events are only the tip of the iceberg.

@foolip
Copy link
Member

foolip commented Feb 1, 2016

Oh, so this is why scrolling the page is enough to clear the media playback restrictions in Blink :)

@jeisinger
Copy link
Member

Anything you manage to come up with that reduces the number of scenarios where we instantiate an UGI that doesn't break all of the interwebs...

@domenic
Copy link
Member

domenic commented Apr 10, 2017

It looks like this got duplicated into #1358 and solved in #1875. The algorithm still has overall problems, which is tracked as #1903.

@domenic domenic closed this as completed Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants