Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events list that trigger "allowed to show a popup" seems too small #1358

Closed
domenic opened this issue May 31, 2016 · 3 comments
Closed

Events list that trigger "allowed to show a popup" seems too small #1358

domenic opened this issue May 31, 2016 · 3 comments

Comments

@domenic
Copy link
Member

domenic commented May 31, 2016

(#1357 renames it to "triggered by user activation" but the issue here remains.)

Currently the list is

  • change
  • click
  • dblclick
  • mouseup
  • reset
  • submit

I wonder if this matches implementations? It seems like touch events and pointer events are missing. (Or are they not necessary since they will always happen alongside a click?) What about mousedown?
@domenic domenic mentioned this issue May 31, 2016
Closed
@RByers
Copy link

RByers commented Jun 2, 2016

Chrome's implementation is more complex than just a list of events. See discussion here.

@domenic domenic mentioned this issue Jun 6, 2016
Closed
@annevk
Copy link
Member

annevk commented Jul 21, 2016

What I said elsewhere is that I think this should become an annotation on a task. The user agent ends up queuing certain tasks in response to user action. It should annotate those tasks (similar to how Fetch annotates tasks) and then APIs can look at that annotation.

Then the standards defining user interaction should decide when to annotate the task.

(I realize we're likely stuck with the current setup for a while, since user interaction standards are extremely lacking and have been for a long time, but I figured I'd mention my thoughts on a better model.)

@domenic domenic mentioned this issue Oct 7, 2016
Merged
domenic pushed a commit that referenced this issue Oct 12, 2016
@NavidZ @domenic
Consider pointerup and touchend for "triggered by user activation"
adafe99 
Although there are larger issues with this definition (see #1358), the
specific lack of these events was causing implementation confusion, so
they are worth adding before fixing the definition more generally.
@domenic domenic mentioned this issue Oct 15, 2016
Closed
@domenic
Copy link
Member Author

domenic commented Oct 15, 2016

Moving to #1903

@domenic domenic closed this as completed Oct 15, 2016
@domenic domenic mentioned this issue Apr 10, 2017
Closed
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@NavidZ
Consider pointerup and touchend for "triggered by user activation"
bead070 
Although there are larger issues with this definition (see whatwg#1358), the
specific lack of these events was causing implementation confusion, so
they are worth adding before fixing the definition more generally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @RByers @annevk