Fix document.domain for IPv6 addresses to match browser behavior with respect to brackets #670
Comments
|
Could you be a bit more specific? It includes plenty of phrases like "If the new value is an IPv4 or IPv6 address", with the definition "If the document's domain starts with a U+005B LEFT SQUARE BRACKET character ([) and ends with a U+005D RIGHT SQUARE BRACKET character (]), it is an IPv6 address". What is some example code setting or getting document.domain that you think the spec is unclear on how to process? |
|
I don't think the spec is at all unclear here. It's very clear: The problem is that this does not match any browsers except Firefox (at least as reported in https://bugzilla.mozilla.org/show_bug.cgi?id=583170) and Firefox just changed its behavior to match the other browsers. So now the spec doesn't match any browsers at all for the getter. There are also open questions about how the setter should behave; testing is needed to see what different browsers do here. |
|
Let's repurpose the bug then! Renaming... |
domenic
changed the title
This fixes #670 by no longer special casing IPv6. And rather than mentioning IPv4 and IPv6 directly, we instead rely on the domain concept. It changes the definition of document.domain to rely on an internal slot rather than somehow changing itself. It makes use of the host parser rather than “domain to ASCII” which is way too low-level to be used here. Potential follow up here is when “registrable domain” gets defined as per whatwg/url#72 so we no longer have to rely on Public Suffix directly.
This fixes #670 by no longer special casing IPv6. And rather than mentioning IPv4 and IPv6 directly, we instead rely on the domain concept. It changes the definition of document.domain to rely on an internal slot rather than somehow changing itself. It makes use of the host parser rather than “domain to ASCII” which is way too low-level to be used here. Potential follow up here is when “registrable domain” gets defined as per whatwg/url#72 so we no longer have to rely on Public Suffix directly.
This fixes #670 by no longer special casing IPv6. And rather than mentioning IPv4 and IPv6 directly, we instead rely on the domain concept. It changes the definition of document.domain to rely on an internal slot rather than somehow changing itself. It makes use of the host parser rather than “domain to ASCII” which is way too low-level to be used here. Potential follow up here is when “registrable domain” gets defined as per whatwg/url#72 so we no longer have to rely on Public Suffix directly.
https://bugzilla.mozilla.org/show_bug.cgi?id=583170#c7
The spec [1] is vague when it defines the behaviour of document.domain for IPv6 domains, and when square brackets should be present.
[1] https://html.spec.whatwg.org/multipage/browsers.html#relaxing-the-same-origin-restriction
The text was updated successfully, but these errors were encountered: