Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use positive number instead of non-negative number greater than zero #8926

Closed
annevk opened this issue Feb 21, 2023 · 1 comment · Fixed by #8931
Closed

Use positive number instead of non-negative number greater than zero #8926

annevk opened this issue Feb 21, 2023 · 1 comment · Fixed by #8931
Labels
clarification Standard could be clearer topic: reflect For issues with reflected IDL attributes and friends

Comments

@annevk
Copy link
Member

annevk commented Feb 21, 2023

https://www.w3.org/Bugs/Public/show_bug.cgi?id=7211#c2 has the historical argument for why it is this way, but searching around for "positive number" and "positive integer" I don't really find evidence of such confusion.
@annevk annevk added the clarification Standard could be clearer label Feb 21, 2023
@annevk annevk mentioned this issue Feb 21, 2023
Merged
@whatwg whatwg deleted a comment Feb 22, 2023
annevk added a commit that referenced this issue Feb 22, 2023
@annevk
Make reflect work for ElementInternals
b739da3 
Other changes:

* Remove reflection of unrestricted double as it is buggy and unused.
* The DOMString getter steps did not account for a missing attribute.
* The native accessibility semantics map was renamed to the internal content attribute map as it's now a more general reflection concept.

Corresponding ARIA PR: w3c/aria#1876.

Fixes #8442.

Follow-up:

* w3c/core-aam#152
* w3c/aria#1110
* #3238
* #8544
* #8545
* #8926
* #8927
* #8928
* #8930
annevk added a commit that referenced this issue Feb 22, 2023
@annevk
Editorial: formalize reflect's default value
8bc3a37 
And rename some number-related options to be less verbose and more consistent.

Fixes #8926 and fixes #8927.
@annevk annevk mentioned this issue Feb 22, 2023
Merged
@tabatkins
Copy link
Contributor

I agree with Ian's historical argument that "positive", by itself, is genuinely unclear whether zero is included or not. Whether zero is positive, negative, or neither varies by context (in the real numbers it's neither, in JS it's either positive or negative, etc), so one cannot infer generally that "positive" includes or excludes zero.

However, I agree that the wording currently used is awkward. I recommend "positive non-zero number", as a shorter and either equally or more clear wording.

annevk added a commit that referenced this issue Feb 27, 2023
@annevk
Editorial: formalize reflect's default value
a32ab9b 
And rename some number-related options to be less verbose and more consistent.

Fixes #8926 and fixes #8927.
@annevk annevk added the topic: reflect For issues with reflected IDL attributes and friends label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer topic: reflect For issues with reflected IDL attributes and friends
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: formalize reflect's default value whatwg/html
2 participants
@tabatkins @annevk