Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fragment parsing algorithm steps to only take Element #10435

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Jun 25, 2024

It isn't passed a DocumentFragment from anywhere.

If it were to be this algorithm would need adjusting, as the HTML fragment parsing algorithm only takes an Element.

Fixes #10434

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/dynamic-markup-insertion.html ( diff )

It isn't passed a DocumentFragment from anywhere.

If it were to be this algorithm would need adjusting, as the HTML fragment parsing algorithm only takes an Element.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit 25aaad7 into whatwg:main Jun 26, 2024
2 checks passed
@lukewarlow lukewarlow deleted the fragment-parse-fix branch June 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fragment parsing algorithm steps take DocumentFragment but it's never used
2 participants