Meta: appreciate web-platform-tests for normative changes #1850
Conversation
foolip
added
the
do not merge yet
|
(We've been using "Meta:" instead of "Editorial:" for this sort of thing.) |
foolip
changed the title
foolip
changed the title
foolip
force-pushed
the
require-tests
branch
3 times, most recently
from
795f354
to
86e4c06
Compare
foolip
changed the title
|
Some more tweaking of the wording, can you take a look, @annevk? |
foolip
removed
the
do not merge yet
| @@ -18,6 +18,10 @@ Please add your name to the Acknowledgements section (search for `<!-- ACKS`) in | |||
|
|
|||
| To preview your changes locally, follow the instructions in the [html-build repository](https://github.com/whatwg/html-build). | |||
|
|
|||
| #### Tests | |||
|
|
|||
| For normative changes, a corresponding [web-platform-tests](https://github.com/w3c/web-platform-tests) PR is highly appreciated. The author and reviewer can be different than for the spec change. If testing is not practical, please explain why and if appropriate file an issue to follow up later. | |||
There was a problem hiding this comment.
s/spec change/change to the standard/
Also link "file an issue" to https://github.com/w3c/web-platform-tests/issues/new. LGTM with that, but probably someone else should sign off too given we already had a longer chat about this.
There was a problem hiding this comment.
I'll also ask that the html label is added, so that we can triage these issues.
There was a problem hiding this comment.
"different than for the change to the standard" become not very readable, so I'll make it "HTML Standard PR" instead.
foolip
force-pushed
the
require-tests
branch
2 times, most recently
from
5bb54a0
to
9cd1a45
Compare
|
I'm happy with the state of this now. Assigning to those I'd like sign off from. |
| @@ -18,6 +18,10 @@ Please add your name to the Acknowledgements section (search for `<!-- ACKS`) in | |||
|
|
|||
| To preview your changes locally, follow the instructions in the [html-build repository](https://github.com/whatwg/html-build). | |||
|
|
|||
| #### Tests | |||
|
|
|||
| For normative changes, a corresponding [web-platform-tests](https://github.com/w3c/web-platform-tests) PR is highly appreciated. The author and reviewer can be different than for the HTML Standard PR. If testing is not practical, please explain why and if appropriate [file an issue](https://github.com/w3c/web-platform-tests/issues/new) with the `html` label to follow up later. | |||
There was a problem hiding this comment.
Not everyone can add labels, so maybe that's not really practical? Though if the issue contains a link to a whatwg/html issue or PR or a link to the spec itself, we can search for "whatwg html".
There was a problem hiding this comment.
Hmm, should I just drop the label bit?
There was a problem hiding this comment.
Yeah, maybe the label bit should be advice in TEAM.
There was a problem hiding this comment.
Moved to TEAM.md with some more words.
| @@ -18,6 +18,10 @@ Please add your name to the Acknowledgements section (search for `<!-- ACKS`) in | |||
|
|
|||
| To preview your changes locally, follow the instructions in the [html-build repository](https://github.com/whatwg/html-build). | |||
|
|
|||
| #### Tests | |||
|
|
|||
| For normative changes, a corresponding [web-platform-tests](https://github.com/w3c/web-platform-tests) PR is highly appreciated. The author and reviewer can be different than for the HTML Standard PR. If testing is not practical, please explain why and if appropriate [file an issue](https://github.com/w3c/web-platform-tests/issues/new) with the `html` label to follow up later. | |||
Part of #1849.