Simplify the definition of the "entry" concept #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the "entrance counter" concept was unnecessary. Whenever we run script, we increment it, and whenever we clean up after running script, we decrement it. So it is always nonzero. Thus we can simply look for whether it's a realm execution context. Fixes #2441.
jensl
reviewed
Apr 3, 2017
source
Outdated
| @@ -120075,6 +120069,7 @@ INSERT INTERFACES HERE | |||
| Jens Fendler, | |||
| Jens Lindström, | |||
There was a problem hiding this comment.
"Jens Lindström" used to be me, before I got married. Might make sense to remove this entry, now that my new name was added to the list.
zcorpan
approved these changes
Apr 18, 2017
There was a problem hiding this comment.
I discussed this with @jensl to try to understand what's going on here. Since the counter is unused it can be removed without any normative change. Having it there opens the opportunity for bugs of using the wrong realm. No new tests needed for this change, but having tests in general for multiple globals/environment settings objects/etc would be good.
|
Looks good to me. Sorry, I thought I had said that earlier.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the "entrance counter" concept was unnecessary.
Whenever we run script, we increment it, and whenever we clean up after
running script, we decrement it. So it is always nonzero. Thus we can
simply look for whether it's a realm execution context.
Fixes #2441.
/cc @jensl @bzbarsky. This should be effectively an editorial change.