Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection/text entry cursor position processing for input/textarea #3472

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Fix selection/text entry cursor position processing for input/textarea #3472

merged 3 commits into from
Mar 16, 2018

Commits on Mar 16, 2018

  1. Editorial: clarify some text selection/cursor concepts 

    This gives explicit definitions to the concepts of "selection", "text
entry cursor position", and "relevant value" for selection/cursor
purposes.
    @domenic
    domenic committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    8f69421 View commit details
    Browse the repository at this point in the history

  2. Change textarea's relevant value to its API value 

    Per the test case included as an example in the spec, this is more in
line with browser behavior, and makes more sense. A similar conclusion
was reached on related matters in
#2424, and also in
#2437.
    @domenic
    domenic committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    0b9ee5d View commit details
    Browse the repository at this point in the history

  3. Clamp selection and text entry cursor position on value changes 

    Fixes #2424. Fixes #2411. Fixes #3468.
    @domenic
    domenic committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    8baa46b View commit details
    Browse the repository at this point in the history