Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate paint timing monkey patching #3923

Merged
merged 12 commits into from
Aug 16, 2018
Merged

Eliminate paint timing monkey patching #3923

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef50cec
Eliminate Paint Timing monkey patching
tdresser Jul 5, 2018
580e2fc
WIP: improve notes on reasons to bail
tdresser Jul 13, 2018
80313b1
Time to sort out coalesced tasks
tdresser Jul 13, 2018
6e5475c
Handle task coalescing
tdresser Jul 13, 2018
cec851e
Address feedback
tdresser Aug 15, 2018
f0df7a0
Merge pull request #1 from tdresser/paint-timing-integration
tdresser Aug 15, 2018
fa4c28e
fix conformance error
tdresser Aug 15, 2018
f6f875c
Source formatting indentation
domenic Aug 16, 2018
53a4444
present -> presentable? Check me on this
domenic Aug 16, 2018
eb79a83
is in -> is
domenic Aug 16, 2018
e5a5a0c
Move some of the big note into its own non-note paragraph
domenic Aug 16, 2018
545cdbd
B -> browsingContexts
domenic Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89002,7 +89002,7 @@ dictionary <dfn>PromiseRejectionEventInit</dfn> : <span>EventInit</span> {
<p><i>Rendering opportunites</i>: If there are <span data-x="browsing context">browsing
contexts</span> <var>B</var> that do not have a <span>rendering opportunity</span>, then
remove from <var>docs</var> all <code>Document</code> objects whose <span
data-x="concept-document-bc">browsing context</span> is in <var>B</var>.</p>
data-x="concept-document-bc">browsing context</span> is <var>B</var>.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, B is a list of browsing contexts, so I think this was correct previously?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great catch. I'll rename to "browsingContexts" for clarity. (There is also a "B" up in step 7.2, which technically doesn't collide.)


<p>A <span>browsing context</span> has a <dfn>rendering opportunity</dfn> if the user agent is
currently able to present the contents of the <span>browsing context</span> to the user,
Expand Down