Define serialization and deserialization steps for Error #4665

yutakahirano · 2019-05-28T06:22:44Z

Define serialization and deserialization steps for Error objects. This change doesn't cover DOMExceptions, which will be covered by whatwg/webidl#729.

Fixes #4268 in combination with whatwg/webidl#729.

At least two implementers are interested (and none opposed):
- Blink
- Gecko
Tests are written and can be reviewed and commented upon at:
- Add structured clone tests for errors web-platform-tests/wpt#17095
- Add optional test for cloning of error stacks web-platform-tests/wpt#17159
Implementation bugs are filed:
- Chrome: https://crbug.com/970079
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1556604
- Safari: https://bugs.webkit.org/show_bug.cgi?id=198511

(See WHATWG Working Mode: Changes for more details.)

/infrastructure.html ( diff )
/references.html ( diff )
/structured-data.html ( diff )

TimothyGu

I don't see deserialization included in this PR yet. I assume this is a WIP?

source

yutakahirano · 2019-05-28T08:15:14Z

As in the first comment this change is not ready for review yet.

yutakahirano · 2019-05-28T09:53:24Z

Although I haven't written tests yet, I think the change is ready for review. I will write tests probably tomorrow.

cc: @domenic

domenic

LGTM with some nits that I touched up; nice work!

domenic · 2019-05-29T18:42:28Z

source

+    <ol>
+     <li><p>Let <var>prototype</var> be "Error".</p></li>
+
+     <li><p>Let <var>valueProto</var> be ! <var>value</var>.[[GetPrototypeOf]]().</p></li>


Because of the preconditions, I am 95% sure this is equivalent to your version, which checked [[Prototype]] directly each time. It's just a bit nicer to go through the semi-public API of [[GetPrototypeOf]](), which will return [[Prototype]].

source

domenic · 2019-05-29T19:10:38Z

I'll note that I'm not attached to the current design for getting the message, which emerged through conversations in #4665 (comment). We could, for example, also refuse to serialize the message if it's a non-string. Or we could always serialize the message, including any on the prototype chain, which would result in no-message errors coming out the other side with empty-string messages. I don't feel strongly; the current PR just represents something that seems vaguely reasonable.

source

yutakahirano · 2019-05-30T06:56:49Z

Tests are available at web-platform-tests/wpt#17095.

This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732

This is a reland of https://crrev.com/c/v8/v8/+/1692366. The original change was reverted because it broke some blink tests. This will be landed after suppressing them: https://crrev.com/c/chromium/src/+/1695541 Make native errors serializable. The implementation is mostly straightforward, but there is one exception: the stack property. Although the property is not specified, the spec for error cloning asks us to preserve the property if possible. This implementation serializes the property only when it is a string, and otherwise ignores it. Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: chromium:970079, v8:9462 Change-Id: Ibf012754f30237f6b5acf119ef834e73727a230f Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695202 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62659}

Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e

Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#678728}

…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 --HG-- rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-iframe.html => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html rename : testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/resources/echo-worker.js => testing/web-platform/tests/html/infrastructure/safe-passing-of-structured-data/resources/echo-worker.js

…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095

…Error structured cloning, a=testonly Automatic update from web-platform-tests Fix and re-enable web tests affected by Error structured cloning Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#678728} -- wpt-commits: c1e9969044fed6bf1bd9d0a5cb1630845cde70fb wpt-pr: 17872

…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159

…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095

…Error structured cloning, a=testonly Automatic update from web-platform-tests Fix and re-enable web tests affected by Error structured cloning Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#678728} -- wpt-commits: c1e9969044fed6bf1bd9d0a5cb1630845cde70fb wpt-pr: 17872

Supplements web-platform-tests#17095. Follows whatwg/html#4665 and whatwg/webidl#732.

This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732

Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#678728}

…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e

…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731

…Error structured cloning, a=testonly Automatic update from web-platform-tests Fix and re-enable web tests affected by Error structured cloning Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhiranochromium.org> Reviewed-by: Joshua Bell <jsbellchromium.org> Reviewed-by: Majid Valipour <majidvpchromium.org> Cr-Commit-Position: refs/heads/master{#678728} -- wpt-commits: c1e9969044fed6bf1bd9d0a5cb1630845cde70fb wpt-pr: 17872 UltraBlame original commit: 245fb2b7a2561a3a123abc430714e85f363dbf8b

…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e

…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731

…Error structured cloning, a=testonly Automatic update from web-platform-tests Fix and re-enable web tests affected by Error structured cloning Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhiranochromium.org> Reviewed-by: Joshua Bell <jsbellchromium.org> Reviewed-by: Majid Valipour <majidvpchromium.org> Cr-Commit-Position: refs/heads/master{#678728} -- wpt-commits: c1e9969044fed6bf1bd9d0a5cb1630845cde70fb wpt-pr: 17872 UltraBlame original commit: 245fb2b7a2561a3a123abc430714e85f363dbf8b

…tacks, a=testonly Automatic update from web-platform-tests Add optional test for cloning of error stacks Supplements web-platform-tests/wpt#17095. Follows whatwg/html#4665 and whatwg/webidl#732. -- wpt-commits: 1da6bed5d8c4c38200383b86928b7be68bfb87da wpt-pr: 17159 UltraBlame original commit: d0647ab7df5d71c33b5c35b8b4ce69940975639e

…=testonly Automatic update from web-platform-tests Add structured clone tests for errors This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732 -- Add tests for cloning from another realm -- Test some stuff before cloning -- wpt-commits: 1b4fbe0c7049d89fd805dc157f68d82616f5d203, efc79eef01ffa65273ff01736d989ff5fa79f18d, 84af6c875d378944b39d895acdcfc170736b2d3d wpt-pr: 17095 UltraBlame original commit: 696cf52f476f2f644137d19d9b9c4ec4dc400731

…Error structured cloning, a=testonly Automatic update from web-platform-tests Fix and re-enable web tests affected by Error structured cloning Fix tests and expectations for Error structured cloning Spec: whatwg/html#4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhiranochromium.org> Reviewed-by: Joshua Bell <jsbellchromium.org> Reviewed-by: Majid Valipour <majidvpchromium.org> Cr-Commit-Position: refs/heads/master{#678728} -- wpt-commits: c1e9969044fed6bf1bd9d0a5cb1630845cde70fb wpt-pr: 17872 UltraBlame original commit: 245fb2b7a2561a3a123abc430714e85f363dbf8b

Define serialization and deserialization steps for Error

287b408

TimothyGu reviewed May 28, 2019

View reviewed changes

source Outdated Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

yutakahirano added 8 commits May 28, 2019 17:55

fix

c2ebc98

fix

f6fadbd

fix

096821e

fix

1217f55

fix

f0f7f51

fix

6ea4e85

fix

6de07f0

fix

a15fc66

Editorial tweaks

9a7b395

domenic approved these changes May 29, 2019

View reviewed changes

domenic reviewed May 29, 2019

View reviewed changes

source Show resolved Hide resolved

Oh, we need the [[ErrorData]] internal slot too

8dc7f9f

domenic added addition/proposal New features or enhancements topic: serialize and transfer labels May 29, 2019

Fix to only get the own property, per bakkot

f269864

TimothyGu reviewed May 29, 2019

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

fix

c9f049f

yutakahirano mentioned this pull request May 30, 2019

Add structured clone tests for errors web-platform-tests/wpt#17095

Merged

Abenteurer88 approved these changes Jun 1, 2019

View reviewed changes

domenic mentioned this pull request Jun 3, 2019

Structured cloning of errors mozilla/standards-positions#165

Closed

yutakahirano added 3 commits June 4, 2019 13:04

fix

2fe45f8

fix

48a6cc3

fix

0d987f3

foolip pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 10, 2019

Add structured clone tests for errors

1b4fbe0

This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732

chromium-wpt-export-bot mentioned this pull request Jul 17, 2019

Fix and re-enable web tests affected by Error structured cloning web-platform-tests/wpt#17872

Merged

natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019

Add optional test for cloning of error stacks

a77cab6

Supplements web-platform-tests#17095. Follows whatwg/html#4665 and whatwg/webidl#732.

natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019

Add structured clone tests for errors

7b44ad5

This is tests for spec changes. - whatwg/html#4665 - whatwg/webidl#732

hober mentioned this pull request Dec 10, 2019

HTML horizontal review: Scripting w3ctag/design-reviews#457

Closed

3 tasks

yutakahirano mentioned this pull request Aug 6, 2020

Expand JS error serialization #5749

Open

3 tasks

domenic mentioned this pull request Feb 9, 2022

Copy over the error from inside workers to the Worker error event? #7596

Open

hamishwillee mentioned this pull request May 6, 2022

DOMException is serialisable mdn/browser-compat-data#16148

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define serialization and deserialization steps for Error #4665

Define serialization and deserialization steps for Error #4665

yutakahirano commented May 28, 2019 •

edited by pr-preview bot

Loading

TimothyGu left a comment

yutakahirano commented May 28, 2019

yutakahirano commented May 28, 2019

domenic left a comment

domenic May 29, 2019 •

edited

Loading

domenic commented May 29, 2019

yutakahirano commented May 30, 2019

Define serialization and deserialization steps for Error #4665

Define serialization and deserialization steps for Error #4665

Conversation

yutakahirano commented May 28, 2019 • edited by pr-preview bot Loading

TimothyGu left a comment

Choose a reason for hiding this comment

yutakahirano commented May 28, 2019

yutakahirano commented May 28, 2019

domenic left a comment

Choose a reason for hiding this comment

domenic May 29, 2019 • edited Loading

Choose a reason for hiding this comment

domenic commented May 29, 2019

yutakahirano commented May 30, 2019

yutakahirano commented May 28, 2019 •

edited by pr-preview bot

Loading

domenic May 29, 2019 •

edited

Loading