Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consult .name instead of [[Prototype]] for Error serialization #5150

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

domenic
Copy link
Member

@domenic domenic commented Dec 13, 2019

Fixes #5140.

(See WHATWG Working Mode: Changes for more details.)


/structured-data.html ( diff )

@yutakahirano
Copy link
Member

LGTM

source Show resolved Hide resolved
@domenic domenic requested a review from annevk January 6, 2020 19:38
@annevk
Copy link
Member

annevk commented Jan 7, 2020

I think it's okay to assume Mozilla is okay with this.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though Mozilla would most likely prefer accepting that errors have an internal slot, as they do in all implementations.

domenic added a commit to web-platform-tests/wpt that referenced this pull request Jan 7, 2020
@domenic domenic merged commit aeee879 into master Jan 7, 2020
@domenic domenic deleted the domenic/better-cross-realm-errors branch January 7, 2020 17:28
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jan 9, 2020
…erialization, a=testonly

Automatic update from web-platform-tests
Add/update tests for cross-realm Error serialization

Follows whatwg/html#5150.
--

wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846
wpt-pr: 20771
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 9, 2020
…erialization, a=testonly

Automatic update from web-platform-tests
Add/update tests for cross-realm Error serialization

Follows whatwg/html#5150.
--

wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846
wpt-pr: 20771
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Jan 11, 2020
…erialization, a=testonly

Automatic update from web-platform-tests
Add/update tests for cross-realm Error serialization

Follows whatwg/html#5150.
--

wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846
wpt-pr: 20771

UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Jan 11, 2020
…erialization, a=testonly

Automatic update from web-platform-tests
Add/update tests for cross-realm Error serialization

Follows whatwg/html#5150.
--

wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846
wpt-pr: 20771

UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 11, 2020
…erialization, a=testonly

Automatic update from web-platform-tests
Add/update tests for cross-realm Error serialization

Follows whatwg/html#5150.
--

wpt-commits: 9882946dd9fcf7251387c2bfc778331b7ae85846
wpt-pr: 20771

UltraBlame original commit: 7c9c630320f2c445b07311327a2bd62e52a3278f
johanholmerin added a commit to johanholmerin/structured-clone that referenced this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Reconsider structured cloning of errors to use .name instead of [[GetPrototypeOf]]
3 participants