Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: pop-up → popup #5499

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Editorial: pop-up → popup #5499

merged 1 commit into from
Apr 30, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 30, 2020 •
edited by pr-preview bot
Loading

domenic
domenic approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're pretty committed to this given the existence of allow-popups (instead of allow-pop-ups).

@domenic domenic merged commit f7882ff into master Apr 30, 2020
@domenic domenic deleted the annevk/pop-up branch April 30, 2020 16:43
annevk added a commit to whatwg/whatwg.org that referenced this pull request May 1, 2020
@annevk
Add popup to the Style Guide
9cff9fe 
Follows whatwg/html#5499.
@annevk annevk mentioned this pull request May 1, 2020
Merged
domenic pushed a commit to whatwg/whatwg.org that referenced this pull request May 1, 2020
@annevk @domenic
Add popup to the Style Guide
fdc3a63 
Follows whatwg/html#5499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic