Editorial: Have the multipart/form-data encoding algorithm use "encode" #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After whatwg/url#558, the form submission algorithm is the only place in the web platform that uses "encode". However, although for application/x-www-form-urlencoded and text/plain "encode" is clearly linked, multipart/form-data instead describes an equivalent algorithm. This change fixes that.
annevk
reviewed
Nov 10, 2020
| <var>encoding</var>, converted to a byte sequence. In the case of file names, however, the | ||
| precise name may be approximated if necessary (e.g. newlines could be removed from file names, | ||
| quotes could be changed to "%22", and characters not expressible in <var>encoding</var> could | ||
| be replaced by other characters before encoding).</p></li> |
There was a problem hiding this comment.
I guess as a follow-up we should test if this is what user agents do.
There was a problem hiding this comment.
My thoughts exactly.
domenic
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After whatwg/url#558, the form submission algorithm is the only place in the web platform that uses "encode". However, although for
application/x-www-form-urlencodedandtext/plain"encode" is clearly linked,multipart/form-datainstead describes an equivalent algorithm. This change fixes that./form-control-infrastructure.html ( diff )