Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make details styles match implementation. #8780

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Make details styles match implementation. #8780

merged 1 commit into from
Jan 27, 2023

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 26, 2023 •
edited by pr-preview bot
Loading

There's not any mention of the fallback summary which is rather unfortunate?

Fixes #8610

  • At least two implementers are interested (and none opposed):
    • Gecko (reporter)
    • Blink (see comments in issue)
  • Tests are written and can be reviewed and commented upon at:
    • We have tests relying on this already because they failed when I tried to change Gecko, but happy to write a more explicit test.
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)

/rendering.html ( diff )

@emilio
Make details styles match implementation.
c190cc5 
There's not any mention of the fallback summary which is rather
unfortunate?

Fixes whatwg#8610
@domenic domenic merged commit 0f1d234 into whatwg:main Jan 27, 2023
@emilio emilio deleted the details-styles branch June 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: style
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details and summary styles don't match implementations.
2 participants
@emilio @domenic