Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw when popover/dialog is in requested state #9142

Merged
merged 7 commits into from
May 9, 2023
Merged

Don't throw when popover/dialog is in requested state #9142

merged 7 commits into from
May 9, 2023

Commits on Apr 10, 2023

  1. Don't throw when popover/dialog is in requested state 

    This patch makes the following changes:
- Don't throw exceptions when showPopover or hidePopover is called and
  the popover is already in the requested state.
- Don't throw exceptions when dialog.showModal, dialog.show, or
  dialog.close is called and the dialog is already in the
  requested state.
- Throw exceptions when trying to switch between modal and non-modal
  dialog modes via dialog.showModal or dialog.show.

Fixes whatwg#9045
    @josepharhar
    josepharhar committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    4c081c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. fix typo

    @josepharhar
    josepharhar committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    bbdd1f3 View commit details
    Browse the repository at this point in the history

  2. Merge with some upstream commits

    @josepharhar
    josepharhar committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    9f2de61 View commit details
    Browse the repository at this point in the history

  3. fix show() exception

    @josepharhar
    josepharhar committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    23df735 View commit details
    Browse the repository at this point in the history

  4. fix disconnected exception

    @josepharhar
    josepharhar committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0800430 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. move connected check after requested state check

    @josepharhar
    josepharhar committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ecdbdfa View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Merge with upstream commits

    @josepharhar
    josepharhar committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2177155 View commit details
    Browse the repository at this point in the history