Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showPicker to <select> elements #9754

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Add showPicker to <select> elements #9754

merged 9 commits into from
Nov 16, 2023

Commits on Sep 19, 2023

  1. Add showPicker to <select> elements 

    Closes whatwg#7957
    @lukewarlow
    lukewarlow committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    2e5b8a2 View commit details
    Browse the repository at this point in the history

  2. Combine showPicker algorithms

    @lukewarlow
    lukewarlow committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    342dee6 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Mention element focus

    @lukewarlow
    lukewarlow committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9e56118 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Remove focus mention and address nits

    @lukewarlow
    lukewarlow committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    774c98c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Add line to say picker interface must be focused.

    @lukewarlow
    lukewarlow committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c36752e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Remove line that says picker interface must be focused.

    @lukewarlow
    lukewarlow committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8a7786a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Add check that select element is being rendered to showPicker algorithm

    @lukewarlow
    lukewarlow committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5c237e5 View commit details
    Browse the repository at this point in the history

  2. Swap NotAllowedError for NotSupportedError

    @lukewarlow
    lukewarlow committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    daf2c1e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Address review comments

    @lukewarlow
    lukewarlow committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    953c3fe View commit details
    Browse the repository at this point in the history