-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add popover=hint #9778
base: main
Are you sure you want to change the base?
Add popover=hint #9778
Conversation
I would probably want https://github.com/keithamus/invoker-buttons-proposal to be worked on first before addressing this, as I think it's a building block for this and other declarative attributes. |
So I've significantly updated the Indeed both are important bits of functionality, but I'm hoping we can tackle them independently rather than needing to put up another huge spec PR. That didn't work very well for the original Popover spec PR, at least in my opinion. |
Note to self: this will require additional changes in https://chromium-review.googlesource.com/c/chromium/src/+/5229300 if the corresponding PR to be opened gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I reviewed mostly for the correctness of the algorithms, and things look pretty good. I made a few corrections, but other than those, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually looks good, though I think the current getStackPosition behavior is not correct / what we want? I might be wrong tho.
Cool, thanks for the review! Sounds like you're supportive of the PR in general? If so, mind marking that on mozilla/standards-positions#965?
See my comment in the review - let's discuss there. I want to understand a bit better. |
This issue/PR was just discussed at the OpenUI/WHATWG/CSSWG form controls task force meeting, in the context of a more general discussion of the "tooltip" use case. The notes are located here: |
@emilio any thoughts on this one? I.e. adding support (or not) from Mozilla's point of view, for |
I checked the implementer interest box now that mozilla is supportive: mozilla/standards-positions#965 (comment) |
Cool, thanks all. I can file the MDN bug, which looks like the last checkbox to check. Anything else needed here in order to land this? @domenic |
I'd like a chance to review the most recent changes, which will probably have to wait until Monday, but yeah, we should basically be good! |
Sounds great! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a mismatched algorithm call, which I'm not sure how to fix, but otherwise looks good. (Be sure to pull in my nit fix commit as well.)
WebKit is opposed to this. I don't think this should land. |
Thanks for the comment @annevk. Am I to take it that WebKit is invoking the "strongly recommended" working mode criteria that "There should be no strong implementer objections to the new feature."? |
Thanks for the feedback, @annevk. With reference to the Standards of Behavior, I'd like to ask you to "Take actions that are constructive, and move towards consensus when possible". In this case, I think that'd include a lot more detail about the specifics of your objection, including what obstacles we'd have to overcome in order for you to be supportive of this proposal. I presume (but would love confirmation) that your objection here is related to your comment on the standards position request. If so, could you point out the person we should be talking to in order to co-design a tooltip/hovercard solution that works for Apple? |
Fixes #9776
Explainer: https://open-ui.org/components/popover-hint.research.explainer/#popoverhint-behavior
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )
/popover.html ( diff )