Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guidelines should say something about submitting issues #107

Closed
zcorpan opened this issue Sep 1, 2018 · 2 comments · Fixed by #145
Closed

Contributing guidelines should say something about submitting issues #107

zcorpan opened this issue Sep 1, 2018 · 2 comments · Fixed by #145

Comments

@zcorpan
Copy link
Member

zcorpan commented Sep 1, 2018

@andershol

(I did read the contributing guidelines, but as I read them, they only talk about submitting pull requests and not about submitting issues)

whatwg/html#3983

@andershol
Copy link

Note that I did not argue for anything to be added to the guidelines. New rules should IMHO only be added if they are needed. My comment referred to the note appearing to the right of the form on the "new issue" page. For people that have not opened an issue before it says "It looks like this is your first time opening an issue in this project! Be sure to review the contributing guidelines." (for other people it just say "Helpful resources Contributing"). So you could just remove those seemingly irrelevant reminders/warnings. Most other github projects don't seem to need those.

@zcorpan
Copy link
Member Author

zcorpan commented Sep 1, 2018

I think that's something GitHub does, not something we can control. In any case, I think it can make sense to discuss submitting issues in the contributing guidelines.

annevk added a commit that referenced this issue Sep 26, 2019
annevk added a commit that referenced this issue Sep 26, 2019
Closes #107.

Co-Authored-By: Domenic Denicola <d@domenic.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants