Race between showNotification & getNotifications

[jakearchibald]

registration.showNotification('test', {
  icon: 'notification-icon.png'
}).then(() => registration.getNotifications()).then(notifications => {
  // ...
});

According to the current spec, it seems likely that the notification shown by showNotification won't be in the sequence returned by getNotifications.

showNotification resolves before fetching icons & running display steps, and the notification isn't added to the list of notifications until after the display steps.

Possible solutions: showNotification should resolve later, once the notification is shown. Or, the notification should be added to the list of notifications sooner. Or, getNotifications should wait for pending notifications.

The first solution feels simplest.

[annevk]

That sounds reasonable. I'm not even sure why we resolve early. @beverloo?

[beverloo]

We actually implement that part of the spec incorrectly then - Chrome resolves once the notification has been shown. This really helps in avoiding internal logic for keeping things around until the notification is ready, e.g. after a push event where all browsers currently have notification requirements.

Waiting LGTM.