-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should there be a WritableStream.close() method? #1007
Comments
On the other hand, I don't find the I assume this was a conscious choice when |
It looks like this was more of a historical accident than anything. We intended to add close in #319, but I guess the initial pull requests didn't do so. I'd like to add it. |
Okay. I have no objection. I'm hoping some enthusiastic person will step up with a PR 😄 |
I'll pick this up. Should be simple enough. 🙂 |
Fixed in #1011. |
It appears that currently the only way to close (without aborting) a writable stream is by calling
getWriter
, and then callingclose()
on that writer. Would it make sense to also exposeclose()
directly onWritableStream
itself?Presumably you'd only be able to call such a method if the stream isn't locked (just like abort on the stream can only be called if the stream isn't locked).
The text was updated successfully, but these errors were encountered: