-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert writable stream tests to web platform tests format #492
Comments
I (and @ricea also maybe) are going to work on this. What would the best work flow? Maybe, local review somewhere, and then PR to w3c/. Creating PR to fork would be overkilling, right? Just commit to personal forks and then get them reviewed before upstream PR? |
Oh, very exciting! I think doing something similar to what we did for readable stream makes sense: use this repo as a staging ground and convert the tests here, then when we feel they're "done", move them to WPT in one PR. The benefit there is that we can continue to validate the tests against the reference implementation as we go. |
OK. As we've removed the directory in 85260dc and is now used for checking out wpt from w3c repo, let me create a new directory dedicated for staging/reviewing. |
Hmm, before 85260dc, we had to manually copy the streams test to a full checkout of w3c wpt so that the tests can use e.g. stuff in service-workers/resources? Sorry, I forgot that. Now, to keep the converted wpt tests for writable streams in this repository, basically we need to have a separate directory. To allow the tests in it to use the files (service-workers/resources), we need to create a symlink (not good for Windows checkout?) or (partially) clone the repo. It's not something we want to do, I think. |
Hmm, it's awkward, but negation entry in .gitignore would help. See #510. |
Please leave the piping tests to me and I'll work on converting them as part of #512. |
This commit is for the issue #492. wpt-runner invocation is tweaked by domenic. We'll use the to-upstream-wpts/ directory for placing converted wpt files until it's ready for upstreaming them to the w3c repo. All the tests under the directory are run automatically when we run "npm run wpt" in addition to the ones already moved to the w3c repo.
Got it, domenic. @ricea It's ready for converting more tests into wpt. If you're willing to take some of them, please share which items you're going to take here. Converted tests should be placed in the to-upstream-wpts/ directory. |
I am porting the tests in |
@ricea Awesome, I'll have a go at |
I've updated the OP with a remaining checklist of files to move. |
After #488 lands we should do this
Update 2016-10-25: here is a remaining checklist of files, after #540 lands:
Updated 2016-11-07: #640 is taking care of the above.
The text was updated successfully, but these errors were encountered: