Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge WritableStream tests from close-then-abort branch #694

Closed
tyoshino opened this issue Mar 10, 2017 · 3 comments
Closed

Merge WritableStream tests from close-then-abort branch #694

tyoshino opened this issue Mar 10, 2017 · 3 comments
Labels
reference implementation writable streams

Comments

@tyoshino
Copy link
Member

Merge useful tests from domenic's close-then-abort branch 33773df#diff-4c7e8a1ce50d6c68c3d24df6461fcfd6

See also #672 (comment)
This was referenced Mar 10, 2017
Merged
Closed
@tyoshino
Copy link
Member Author

#672 (comment)

We don't follow the expectation in the Closing but then immediately aborting a WritableStream results in a successful close and a fulfilled abort() test.

@domenic, do you want to choose this behavior? Or are you fine with keeping not yet in-flight close() abort()-able?

@domenic
Copy link
Member

domenic commented Mar 10, 2017

I am fine with keeping not yet in-flight close() abort()-able, as long as we have tests for it :). Maybe we already do.

@tyoshino
Copy link
Member Author

OK. Thanks for confirming!

@domenic domenic mentioned this issue Mar 15, 2017
Closed
domenic added a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2017
@domenic
Add coverage for various aspects of writable stream aborting
f87b053 
This ports the still-applicable test modifications from whatwg/streams@33773df#diff-4c7e8a1ce50d6c68c3d24df6461fcfd6; some of them are different now as we ended up going in a different direction than that branch, but the overall principle of adding more asserts surrounding the events here and using recordingWritableStream more is a good one.

Closes whatwg/streams#694.
@domenic domenic mentioned this issue Mar 28, 2017
Merged
domenic added a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2017
@domenic
Add coverage for various aspects of writable stream aborting
8346b7f 
This ports the still-applicable test modifications from whatwg/streams@33773df#diff-4c7e8a1ce50d6c68c3d24df6461fcfd6; some of them are different now as we ended up going in a different direction than that branch, but the overall principle of adding more asserts surrounding the events here and using recordingWritableStream more is a good one.

Closes whatwg/streams#694.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reference implementation writable streams
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @tyoshino