Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion failure in RespondInternal after transferring array buffer in RespondWithNewView #1174

Merged
merged 10 commits into from
Oct 12, 2021
Merged

Fix assertion failure in RespondInternal after transferring array buffer in RespondWithNewView #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5f36dda
Merge pull request #1 from whatwg/master
nidhijaju Nov 24, 2020
b5dbc0e
Merge pull request #2 from whatwg/master
nidhijaju Dec 1, 2020
f423409
Merge pull request #3 from whatwg/master
nidhijaju Dec 2, 2020
631447b
Merge remote-tracking branch 'upstream/master'
nidhijaju Dec 4, 2020
72e8f57
Merge remote-tracking branch 'upstream/master'
nidhijaju Dec 9, 2020
7c80a45
Merge branch 'whatwg:main' into master
nidhijaju Aug 30, 2021
e1cfefe
Merge branch 'whatwg:main' into master
nidhijaju Aug 31, 2021
8ed62f7
Merge branch 'whatwg:main' into master
nidhijaju Oct 12, 2021
e527b34
store view byte length before transferring
nidhijaju Oct 12, 2021
6626c80
fix in ref impl
nidhijaju Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3489,9 +3489,10 @@ The following abstract operations support the implementation of the
|view|.\[[ViewedArrayBuffer]].\[[ByteLength]], throw a {{RangeError}} exception.
1. If |firstDescriptor|'s [=pull-into descriptor/bytes filled=] + |view|.\[[ByteLength]] >
|firstDescriptor|'s [=pull-into descriptor/byte length=], throw a {{RangeError}} exception.
1. Let |viewByteLength| be |view|.\[[ByteLength]].
1. Set |firstDescriptor|'s [=pull-into descriptor/buffer=] to ?
[$TransferArrayBuffer$](|view|.\[[ViewedArrayBuffer]]).
1. Perform ? [$ReadableByteStreamControllerRespondInternal$](|controller|, |view|.\[[ByteLength]]).
1. Perform ? [$ReadableByteStreamControllerRespondInternal$](|controller|, |viewByteLength|).
</div>

<div algorithm>
Expand Down
4 changes: 3 additions & 1 deletion reference-implementation/lib/abstract-ops/readable-streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,9 +1634,11 @@ function ReadableByteStreamControllerRespondWithNewView(controller, view) {
throw new RangeError('The region specified by view is larger than byobRequest');
}

const viewByteLength = view.byteLength;

firstDescriptor.buffer = TransferArrayBuffer(view.buffer);

ReadableByteStreamControllerRespondInternal(controller, view.byteLength);
ReadableByteStreamControllerRespondInternal(controller, viewByteLength);
}

function ReadableByteStreamControllerShiftPendingPullInto(controller) {
Expand Down