Add tests for interaction between autoAllocateChunkSize and respondWithNewView #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricea
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 9, 2022
…#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887.
MattiasBuelens
deleted the
test-respondwithnewview-autoallocatechunksize
branch
mattwoodrow
pushed a commit
to mattwoodrow/wpt
that referenced
this pull request
Feb 15, 2022
…web-platform-tests#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2022
…locateChunkSize and respondWithNewView, a=testonly Automatic update from web-platform-tests Test interaction between autoAllocateChunkSize and respondWithNewView (#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887. -- wpt-commits: 6a46d9cb8d20c510a620141c721b81b460a4ee55 wpt-pr: 32757
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Feb 28, 2022
…web-platform-tests#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887.
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 1, 2022
…locateChunkSize and respondWithNewView, a=testonly Automatic update from web-platform-tests Test interaction between autoAllocateChunkSize and respondWithNewView (#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887. -- wpt-commits: 6a46d9cb8d20c510a620141c721b81b460a4ee55 wpt-pr: 32757
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2022
…locateChunkSize and respondWithNewView, a=testonly Automatic update from web-platform-tests Test interaction between autoAllocateChunkSize and respondWithNewView (#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887. -- wpt-commits: 6a46d9cb8d20c510a620141c721b81b460a4ee55 wpt-pr: 32757
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 8, 2022
…locateChunkSize and respondWithNewView, a=testonly Automatic update from web-platform-tests Test interaction between autoAllocateChunkSize and respondWithNewView (#32757) See whatwg/streams#1216 for context. Upstreamed from nodejs/node#41887. -- wpt-commits: 6a46d9cb8d20c510a620141c721b81b460a4ee55 wpt-pr: 32757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node had a bug in their readable byte streams implementation when using
respondWithNewView()on an auto-allocated BYOB request, see nodejs/node#41886. Although the specification and the reference implementation handle this use case correctly, it was not covered by any of the existing web platform tests, and thus can be easily missed.This adds tests for the (already specified) expected behavior, to increase test coverage. There are no normative changes.
At least two implementers are interested (and none opposed):Implementation bugs are filed:(See WHATWG Working Mode: Changes for more details.)