When underlyingSink.close() resolves, assert state #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, WritableStreamDefaultControllerProcessClose checked the state was "closing" or "errored" when underlyingSink.close() resolved. In fact it can't be anything else, so make it an assert instead. Thanks to @tyoshino for spotting this.
ricea
referenced
this pull request
Jan 6, 2017
The underlying abort() method will now not be called until any pending underlying write() has finished. If an underlying close() is in progress then abort() will no longer be called at all. Other behavioural changes: * If the underlying operation has started, then the writer's write() and close() methods will always reflect the result of the underlying operation, rather than being rejected because abort() was called. * Consistently with the above, if an underlying operation calls controller.error() then the writer method will still reflect the result from the underlying operation. * If a call to writer.abort() has to wait for an underlying write() or close() to complete, and that underlying operation rejects, then the underlying abort() will not be called, and writer.abort() will return the rejection from the failed operation.
|
lgtm. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, WritableStreamDefaultControllerProcessClose checked the
state was "closing" or "errored" when underlyingSink.close()
resolved. In fact it can't be anything else, so make it an assert
instead.
Thanks to @tyoshino for spotting this.