No need for null passwords #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that preserving the ability to serialize an empty string password is not something any implementation supports. Fixes #181.
annevk
added
the
needs tests
|
To be fair, I haven't tested Safari TP yet, and they went to a lot of trouble to become spec-compliant, so we should check that first... I'm heading into work (and thus to my testing Mac) so I should be able to get back to you soon. |
|
Safari TP normalizes it away. I checked. |
|
The difference between Firefox and others is with |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 29, 2016
URL Standard change: whatwg/url#186.
annevk
removed
the
needs tests
domenic
reviewed
Dec 29, 2016
| <p>If <var>url</var>'s <a for=url>username</a> is not the empty string | ||
| or <var>url</var>'s <a for=url>password</a> is non-null, run these substeps: | ||
| <p>If <var>url</var>'s <a for=url>username</a> or <a for=url>password</a> is not | ||
| the empty string, then: |
There was a problem hiding this comment.
This could probably use the "includes credentials" concept?
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Dec 29, 2016
This aligns with whatwg/url#186.
domenic
approved these changes
Jan 3, 2017
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 3, 2017
URL Standard change: whatwg/url#186.
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jan 3, 2017
This aligns with whatwg/url#186.
jasnell
added a commit
to jasnell/node
that referenced
this pull request
Jan 4, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186. Fixes: nodejs#10595
3 tasks
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Jan 6, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: #10601 Fixes: #10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: nodejs#10601 Fixes: nodejs#10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: nodejs#10601 Fixes: nodejs#10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: nodejs#10601 Fixes: nodejs#10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates null password handling. Refs: web-platform-tests/wpt@e001240 Refs: whatwg/url#186 PR-URL: nodejs#10601 Fixes: nodejs#10595 Reviewed-By: Michal Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bors-servo
pushed a commit
to servo/rust-url
that referenced
this pull request
Oct 31, 2017
Properly handle empty username or password Imports test changes from: web-platform-tests/wpt@e001240 Related URL spec changes: whatwg/url#186 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/406) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that preserving the ability to serialize an empty string
password is not something any implementation supports.
Fixes #181.