Editorial: use specific names for encode sets #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“Simple encode set” is effectively “C0 control encode set” so name it that. And “default encode set” is only used for paths, so name it “path encode set”. Fixes #201.
annevk
force-pushed
the
annevk/encode-set-names
branch
from
8784aa7
to
be94f4a
Compare
domenic
requested changes
Feb 10, 2017
url.bs
Outdated
| @@ -164,11 +164,11 @@ contains bytes that are not <a>ASCII bytes</a> might be insecure and is not reco | |||
|
|
|||
| note that query and application/x-www-form-urlencoded use their own | |||
| local sets --> | |||
| <p>The <dfn>simple encode set</dfn> are <a>C0 controls</a> and all code points greater | |||
| than U+007E. | |||
| <p>The <dfn>C0 control encode set</dfn> are <a>C0 controls</a> and all code points greater than | |||
url.bs
Outdated
| @@ -164,11 +164,11 @@ contains bytes that are not <a>ASCII bytes</a> might be insecure and is not reco | |||
|
|
|||
| note that query and application/x-www-form-urlencoded use their own | |||
| local sets --> | |||
| <p>The <dfn>simple encode set</dfn> are <a>C0 controls</a> and all code points greater | |||
| than U+007E. | |||
| <p>The <dfn>C0 control encode set</dfn> are <a>C0 controls</a> and all code points greater than | |||
There was a problem hiding this comment.
Would a better name be around its usage, which appears to have something to do with percent encoding? Just an idea.
There was a problem hiding this comment.
You want them renamed to percent-encode sets?
There was a problem hiding this comment.
So this would become C0 control percent-encode set?
There was a problem hiding this comment.
No, I didn't remember both were used for percent encoding. Is there a succinct description of where this is used, like "path" or "userinfo"? "C0 control", is what it is, not how it's used.
There was a problem hiding this comment.
All the encode sets are used for percent-encoding.
This one is used by the opaque-host parser, the cannot-be-a-base-URL path state, and the fragment state.
There was a problem hiding this comment.
It sounds like there's no good unifying name for those concepts, so I guess naming it after C0 controls is fine. Shrug.
There was a problem hiding this comment.
Should I name them percent-encode sets though? I agree that there's no good name for this one other than describing what's in it, which seems a little better than "default" or "simple".
There was a problem hiding this comment.
Hmm yeah, I guess while you're here, that might be a nice change as well.
domenic
approved these changes
Feb 13, 2017
There was a problem hiding this comment.
LGTM. @jasnell might want to update the Node documentation too since I noticed it refers to these by their current names: https://nodejs.org/docs/latest/api/url.html#whatwg-percent-encoding
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Feb 16, 2017
This matches the spec change at whatwg/url#243.
4 tasks
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Apr 23, 2017
- Update to spec
- Add opaque hosts
- File state did not correctly deal with lack of base URL
- Cleanup API for file and non-special URLs
- Allow % and IPv6 addresses in non-special URL hosts
- Use specific names for percent-encode sets
- Add empty host concept for file and non-special URLs
- Clarify IPv6 serializer
- Fix existing mistakes
- Add missing ':' to forbidden host code point list.
- Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
- scheme, username, and password should always be strings
- host, port, query, and fragment may be strings or null
- Align scheme state more closely with the spec
- Make sure the `special` variable is always synced with
URL_FLAG_SPECIAL.
PR-URL: nodejs#12523
Fixes: nodejs#10608
Fixes: nodejs#10634
Refs: whatwg/url#185
Refs: whatwg/url#225
Refs: whatwg/url#224
Refs: whatwg/url#218
Refs: whatwg/url#243
Refs: whatwg/url#260
Refs: whatwg/url#268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
TimothyGu
added a commit
to nodejs/node
that referenced
this pull request
Apr 24, 2017
- Update to spec
- Add opaque hosts
- File state did not correctly deal with lack of base URL
- Cleanup API for file and non-special URLs
- Allow % and IPv6 addresses in non-special URL hosts
- Use specific names for percent-encode sets
- Add empty host concept for file and non-special URLs
- Clarify IPv6 serializer
- Fix existing mistakes
- Add missing ':' to forbidden host code point list.
- Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
- scheme, username, and password should always be strings
- host, port, query, and fragment may be strings or null
- Align scheme state more closely with the spec
- Make sure the `special` variable is always synced with
URL_FLAG_SPECIAL.
PR-URL: #12523
Fixes: #10608
Fixes: #10634
Refs: whatwg/url#185
Refs: whatwg/url#225
Refs: whatwg/url#224
Refs: whatwg/url#218
Refs: whatwg/url#243
Refs: whatwg/url#260
Refs: whatwg/url#268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
evanlucas
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 25, 2017
- Update to spec
- Add opaque hosts
- File state did not correctly deal with lack of base URL
- Cleanup API for file and non-special URLs
- Allow % and IPv6 addresses in non-special URL hosts
- Use specific names for percent-encode sets
- Add empty host concept for file and non-special URLs
- Clarify IPv6 serializer
- Fix existing mistakes
- Add missing ':' to forbidden host code point list.
- Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
- scheme, username, and password should always be strings
- host, port, query, and fragment may be strings or null
- Align scheme state more closely with the spec
- Make sure the `special` variable is always synced with
URL_FLAG_SPECIAL.
PR-URL: #12523
Fixes: #10608
Fixes: #10634
Refs: whatwg/url#185
Refs: whatwg/url#225
Refs: whatwg/url#224
Refs: whatwg/url#218
Refs: whatwg/url#243
Refs: whatwg/url#260
Refs: whatwg/url#268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
evanlucas
pushed a commit
to nodejs/node
that referenced
this pull request
May 1, 2017
- Update to spec
- Add opaque hosts
- File state did not correctly deal with lack of base URL
- Cleanup API for file and non-special URLs
- Allow % and IPv6 addresses in non-special URL hosts
- Use specific names for percent-encode sets
- Add empty host concept for file and non-special URLs
- Clarify IPv6 serializer
- Fix existing mistakes
- Add missing ':' to forbidden host code point list.
- Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
- scheme, username, and password should always be strings
- host, port, query, and fragment may be strings or null
- Align scheme state more closely with the spec
- Make sure the `special` variable is always synced with
URL_FLAG_SPECIAL.
PR-URL: #12523
Fixes: #10608
Fixes: #10634
Refs: whatwg/url#185
Refs: whatwg/url#225
Refs: whatwg/url#224
Refs: whatwg/url#218
Refs: whatwg/url#243
Refs: whatwg/url#260
Refs: whatwg/url#268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
evanlucas
pushed a commit
to nodejs/node
that referenced
this pull request
May 2, 2017
- Update to spec
- Add opaque hosts
- File state did not correctly deal with lack of base URL
- Cleanup API for file and non-special URLs
- Allow % and IPv6 addresses in non-special URL hosts
- Use specific names for percent-encode sets
- Add empty host concept for file and non-special URLs
- Clarify IPv6 serializer
- Fix existing mistakes
- Add missing ':' to forbidden host code point list.
- Correct IPv4 parser empty label behavior
- Maintain type equivalence in URLContext with spec
- scheme, username, and password should always be strings
- host, port, query, and fragment may be strings or null
- Align scheme state more closely with the spec
- Make sure the `special` variable is always synced with
URL_FLAG_SPECIAL.
PR-URL: #12523
Fixes: #10608
Fixes: #10634
Refs: whatwg/url#185
Refs: whatwg/url#225
Refs: whatwg/url#224
Refs: whatwg/url#218
Refs: whatwg/url#243
Refs: whatwg/url#260
Refs: whatwg/url#268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Follows whatwg/url#243 "default encode set" --> "path percent-encode set"
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“Simple encode set” is effectively “C0 control encode set” so name it
that. And “default encode set” is only used for paths, so name it “path
encode set”.
Fixes #201.
Preview | Diff