Remove javascript URL special case from the API #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
annevk
added
the
needs tests
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 17, 2017
It makes no sense to just special case them in this IDL attribute anymore, if it ever did. I cannot get a Location object to represent a javascript URL so that case was a no-op and the other case should be aligned with the URL Standard, which changes per whatwg/url#254.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 17, 2017
See whatwg/url#254 and whatwg/html#2371 for changes to the standards.
annevk
removed
the
needs tests
|
Everything ready to go now. |
domenic
approved these changes
Feb 21, 2017
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Feb 21, 2017
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 22, 2017
See whatwg/url#254 and whatwg/html#2371 for changes to the standards.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 22, 2017
It makes no sense to just special case them in this IDL attribute anymore, if it ever did. Javascript URLs might come up again for the Location object per #1565, but for now they cannot be represented there and the other case should be aligned with the URL Standard, which changes per whatwg/url#254.
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Feb 22, 2017
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
It makes no sense to just special case them in this IDL attribute anymore, if it ever did. Javascript URLs might come up again for the Location object per whatwg#1565, but for now they cannot be represented there and the other case should be aligned with the URL Standard, which changes per whatwg/url#254.
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253.
Preview | Diff