IPv4 in IPv6 cleanup #292
Merged
IPv4 in IPv6 cleanup #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll let @domenic verify this in whatwg-url and then land it as an editorial change. LGTM otherwise though. Thanks! |
2 tasks
|
Thanks for putting the discussion into here! +1 |
watilde
added a commit
to watilde/whatwg-url-1
that referenced
this pull request
Apr 12, 2017
watilde
added a commit
to watilde/whatwg-url-1
that referenced
this pull request
Apr 12, 2017
domenic
pushed a commit
to watilde/whatwg-url-1
that referenced
this pull request
Apr 13, 2017
This does not change behavior but keeps us up to date with the spec. Follows whatwg/url#292.
domenic
approved these changes
Apr 13, 2017
domenic
pushed a commit
to jsdom/whatwg-url
that referenced
this pull request
Apr 14, 2017
This does not change behavior but keeps us up to date with the spec. Follows whatwg/url#292.
rmisev
added a commit
to upa-url/upa
that referenced
this pull request
May 24, 2020
Follows whatwg/url#292 Makes (1.) change; the (2.) optimization was done earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Moves ipv4Piece verification step right after the ipv4Piece calculation. Because if the "ipv4Piece > 255" verification returns failure, then no need to increase pointer.
Moves the last (8.) step to the outside of 6.5.5 loop. This lets drop
c is the EOFcheck in this moved step, because loop stops onEOF. This obviously gives a better performance.These changes are based on nodejs/node#12315 (comment) and nodejs/node#12315 (comment)
Preview | Diff