Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify window.webkitURL as an alias to URL #312

Merged
merged 1 commit into from
May 31, 2017
Merged

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 22, 2017

Fixes #135.


Preview | Diff

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request May 22, 2017
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd kinda like to file a Firefox bug first to give them some time to object, but I personally agree that this is the way to go.

This might also be something that Node.js doesn't want to copy. I think we can leave that up to them to decide though.

@zcorpan
Copy link
Member Author

zcorpan commented May 22, 2017

@zcorpan
Copy link
Member Author

zcorpan commented May 22, 2017

@domenic
Copy link
Member

domenic commented May 22, 2017

This might also be something that Node.js doesn't want to copy. I think we can leave that up to them to decide though.

I guess technically Web IDL mandates [LegacyWindowAlias] to apply to the "primary global interface". Maybe we could tweak it to apply to Window only somehow.

But this is minor as Node doesn't implement the global-ness of URL anyway (yet?).

@annevk
Copy link
Member

annevk commented May 22, 2017

@domenic aaah right, that'll be fixed with whatwg/webidl#365 so I think we're totally in the clear then. (Except that at some point Node might want Exposed entries for its global...)

@zcorpan
Copy link
Member Author

zcorpan commented May 23, 2017

Relevant issue for chromium https://bugs.chromium.org/p/chromium/issues/detail?id=348985

@achristensen07
Copy link
Collaborator

Is there a way that chrome stats could measure the uses of webkitURL without URL as a fallback?

@zcorpan
Copy link
Member Author

zcorpan commented May 23, 2017

I don't know how that could reasonably be implemented, since JS execution doesn't reach the fallback, there's no way of knowing what the fallback is.

But if there's still interest to remove it in WebKit, Chromium, and EdgeHTML, it seems plausible that it would be successful since Gecko doesn't have it and has no bugs reported.

Edit: quick compat analysis at #135 (comment)

@zcorpan zcorpan merged commit c643963 into master May 31, 2017
@zcorpan zcorpan deleted the zcorpan/webkiturl branch May 31, 2017 10:17
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request May 31, 2017
@tobie tobie mentioned this pull request Jun 23, 2017
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants