-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify window.webkitURL as an alias to URL #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd kinda like to file a Firefox bug first to give them some time to object, but I personally agree that this is the way to go.
This might also be something that Node.js doesn't want to copy. I think we can leave that up to them to decide though.
I guess technically Web IDL mandates [LegacyWindowAlias] to apply to the "primary global interface". Maybe we could tweak it to apply to Window only somehow. But this is minor as Node doesn't implement the global-ness of URL anyway (yet?). |
@domenic aaah right, that'll be fixed with whatwg/webidl#365 so I think we're totally in the clear then. (Except that at some point Node might want Exposed entries for its global...) |
Relevant issue for chromium https://bugs.chromium.org/p/chromium/issues/detail?id=348985 |
Is there a way that chrome stats could measure the uses of webkitURL without URL as a fallback? |
I don't know how that could reasonably be implemented, since JS execution doesn't reach the fallback, there's no way of knowing what the fallback is. But if there's still interest to remove it in WebKit, Chromium, and EdgeHTML, it seems plausible that it would be successful since Gecko doesn't have it and has no bugs reported. Edit: quick compat analysis at #135 (comment) |
Fixes #135.
Preview | Diff