Clarify output of PSL is in A-Labels #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
reviewed
Apr 26, 2020
url.bs
Outdated
| <a href="https://publicsuffix.org/list/">Public Suffix List algorithm</a> with <var>host</var> as | ||
| domain. [[!PSL]] | ||
|
|
||
| <li><p>Assert: <var>publicSuffix</var> is encoded using A-Labels. [[!UTS46]] |
There was a problem hiding this comment.
UTS 46 doesn't really define what an A-label is, as it only seeks to define a replacement for the processing algorithm. In fact, it defers the definition to RFC 5890 and doesn't use the word at all itself.
Additionally, the term "A-label" exclusively refers to validly encoded labels with xn-- prefix. To refer to all ASCII-encoded labels, it may be better to use either of the following:
Assert: publicSuffix contains only ASCII characters.
or
Assert: Labels in publicSuffix must be either A-labels or NR-LDH labels. [RFC5890]
There was a problem hiding this comment.
I wanted to use UTS46 as an intermediary, but as A-Label doesn't work and NR-LDH isn't mentioned there we'll just assert ASCII code points.
TimothyGu
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396.
Preview | Diff