Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML's parse a URL #380

Closed
annevk opened this issue Sep 3, 2023 · 2 comments · Fixed by #382
Closed

Use HTML's parse a URL #380

annevk opened this issue Sep 3, 2023 · 2 comments · Fixed by #382

Comments

@annevk
Copy link
Member

annevk commented Sep 3, 2023

As https://wpt.fyi/results/html/infrastructure/urls/resolving-urls/query-encoding/windows-1251.html%3Finclude%3Dxhr and surrounding tests indicate all implementations are aligned on not always using UTF-8 as the URL encoding. Given this is an old API it's probably better to standardize on that and change the test expectations.
@annevk annevk mentioned this issue Sep 3, 2023
Open
@annevk
Copy link
Member Author

annevk commented Sep 19, 2023

It seems we already standardized on that https://xhr.spec.whatwg.org/#dom-xmlhttprequest-open and it's just the test expectations that are wrong. Hmm. Oh well, I guess all the refactoring of HTML was good anyway.

@annevk
Copy link
Member Author

annevk commented Sep 19, 2023

web-platform-tests/wpt#42049

annevk added a commit that referenced this issue Sep 19, 2023
@annevk
Editorial: use HTML's encoding-parse a URL
92da04d 
Closes #380.
@annevk annevk mentioned this issue Sep 19, 2023
Merged
annevk added a commit that referenced this issue Sep 22, 2023
@annevk
Editorial: use HTML's encoding-parse a URL
a5597b9 
Closes #380.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: use HTML's encoding-parse a URL whatwg/xhr
1 participant
@annevk