Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rtc custom events map #188

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

thyal
Copy link
Member

@thyal thyal commented Jan 12, 2024

Description

Current implementation works but is error-prone since we just write out action type strings. This means whenever an action creator changes name this list would need to be manually updated, and it's too easy to miss that.

This PR use the action creators directly, and rely on the isAnyOf helper to match on actions.
Depends on #186 because I did some changes to the action creators there.

Summary:

Related Issue:

Testing

Test that the rtc events are still sent. Use #175 test plan.

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Dependency Updates

Reviewers

@havardholvik
@kevinwhereby
@nandito
@thyal

Additional Information

@thyal thyal requested a review from a team January 12, 2024 12:04
@thyal thyal force-pushed the thomas/PAN-501-auto-switch-device branch from 0403e21 to b7db2f1 Compare January 12, 2024 13:45
@thyal thyal force-pushed the thomas/PAN-501-auto-switch-device branch 2 times, most recently from fe342aa to e035012 Compare January 12, 2024 14:31
Base automatically changed from thomas/PAN-501-auto-switch-device to main January 12, 2024 14:41
@thyal thyal force-pushed the thomas/PAN-694-refactor-rtc-analytics-events branch from 9593328 to f214b80 Compare January 12, 2024 14:43
@thyal thyal merged commit 57ab3a6 into main Jan 12, 2024
2 checks passed
@thyal thyal deleted the thomas/PAN-694-refactor-rtc-analytics-events branch January 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants