Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular dep grid component #203

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix circular dep grid component #203

merged 1 commit into from
Feb 1, 2024

Conversation

thyal
Copy link
Member

@thyal thyal commented Feb 1, 2024 •
edited
Loading

Description

A couple of imports where imported from the wrong place, resulting in a circular dependency.

Summary:

Related Issue:

Testing

yarn build -> there should be no warnings

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Dependency Updates

Reviewers

@havardholvik
@kevinwhereby
@nandito
@thyal

Additional Information

@thyal thyal requested a review from a team February 1, 2024 08:31
@nandito nandito changed the title Fix ciruclar dep grid component Fix circular dep grid component Feb 1, 2024
nandito
nandito approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@nandito nandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no warnings 🍰

@thyal thyal merged commit 66361b7 into development Feb 1, 2024
2 checks passed
@thyal thyal deleted the thomas/fix-ciruclar-dep-grid-component branch February 1, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebapawlak sebapawlak sebapawlak approved these changes

@nandito nandito nandito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thyal @sebapawlak @nandito