Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storybook story for testing strict mode #58

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

havardholvik
Copy link
Collaborator

We have some issues with our useRoomConnection hook lifecycle. Add separate story enforcing strict mode to allow for easy debugging.

Tested like

  1. STORYBOOK_ROOM=<your room url> yarn storybook
  2. Open "RoomConnectionStrictMode" story
  3. Verify you get "Trying to join when room state is already connecting" in console

We have some issues with our `useRoomConnection` hook lifecycle. Add
separate story enforcing strict mode to allow for easy debugging.
Copy link
Collaborator

@nandito nandito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the expected message in the console in canvas view. It joins the room in Docs view, but I guess it disables the StrictMode in that mode.

@havardholvik havardholvik merged commit 4ff8a0c into development Aug 28, 2023
1 check passed
@havardholvik havardholvik deleted the holvik/add_strict_mode_story branch August 28, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants