Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query cancellation #18

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support query cancellation #18

wants to merge 3 commits into from

Conversation

mpetazzoni
Copy link
Member

No description provided.

@mpetazzoni
feat: cleanup websocket connection establishment
bfdb6ac 
Additional thread is no longer required since websockets >= 13.0, thanks
to our feedback to the upstream project.
@mpetazzoni
Copy link
Member Author

@peterfoldes I'm specifically interested in your opinion on the protocol versioning aspect here. Note that we're not actually yet putting out a 1.1.0 protocol version on the backend side, so 🤷🏻

Technically, as long as we deploy the support for cancellation on the backend (and don't revert it), we can release the SDK change at any time, all in the same negotiated protocol version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfishel18 sfishel18 sfishel18 left review comments

@peterfoldes peterfoldes Awaiting requested review from peterfoldes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpetazzoni @sfishel18