Make react / react-dom peer dependencies and support react 15. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having react and react-dom as dependencies causes multiple versions of React in bundlers. It seems to be the norm to make them peer dependencies. Any reason for not doing this?
|
Thanks for the PR, I merged it locally with an overhaul I'm in the middle of RC'ing and should have pushed tomorrow (I hope) to address some outstanding issues. |
|
Nice! |
|
Hey @cchamberlain, please give version 5.0.2 a shot when you have the chance. It should be okay (just ran it locally), but I will be keeping a closer eye on issues here in the short term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having react and react-dom as dependencies causes multiple versions of React in bundlers. It seems to be the norm to make them peer dependencies. Any reason for not doing this?