Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/max lines bugs #16

Merged
merged 2 commits into from
Jun 13, 2016
Merged

fix/max lines bugs #16

merged 2 commits into from
Jun 13, 2016

Conversation

skyfe79
Copy link
Contributor

@skyfe79 skyfe79 commented Jun 12, 2016

Hello whilu,

I'm Sungcheol Kim. I'm sorry for a sudden PR to you.
I've forked AndroidTagView for my private usages but I made a mistake to send PR to you. Today, I should send a sudden PR to you again because the PR which was sent to you yesterday has bugs in setting max line count.

I'm so sorry for my rudeness.

Best regards,
Sungcheol Kim

skyfe79 and others added 2 commits June 10, 2016 13:42
support max line count for tag container.
fix bugs which set max line count to 1 forcingly when the tagcontainer was initialized
@whilu
Copy link
Owner

whilu commented Jun 13, 2016

Yeah, I just think your PR with attribute 'max lines' is great, and I have
made some commits depends on your PR but not push, some methods like
'getXX()' or 'setXX()' and so on.
All in all, thanks for your PR! And we will make it better.

2016-06-12 12:30 GMT+08:00 Sungcheol Kim notifications@github.com:

Hello whilu,

I'm Sungcheol Kim. I'm sorry for a sudden PR to you.
I've forked AndroidTagView for my private usages but I made a mistake to
send PR to you. Today, I should send a sudden PR to you again because the
PR which was sent to you yesterday has bugs in setting max line count.

I'm so sorry for my rudeness.

Best regards,

Sungcheol Kim

You can view, comment on, or merge this pull request online at:

#16
Commit Summary

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16, or mute the thread
https://github.com/notifications/unsubscribe/AGkeW-b9IJA83iCIWG02FqR3RB7n_mNtks5qK4twgaJpZM4Izs90
.

@whilu whilu merged commit 1c70dc2 into whilu:master Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants