Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into adding more MusicBrainz identifiers to ripped files #200

Closed
Freso opened this issue Oct 9, 2017 · 4 comments
Closed

Look into adding more MusicBrainz identifiers to ripped files #200

Freso opened this issue Oct 9, 2017 · 4 comments
Assignees
@Freso
Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority
Milestone
1.0

Comments

@Freso
Copy link
Member

Freso commented Oct 9, 2017

Look into whether more MusicBrainz identifiers (namely Release Group, Track, and Work) are included in the response whipper currently gets when looking up Releases, if it does, include these MusicBrainz IDs in the tags added to the resulting files. (If the IDs are not included, don't bother asking for more information in the web service request.)
@JoeLametta JoeLametta added the idea label Oct 9, 2017
@JoeLametta JoeLametta self-assigned this Apr 6, 2018
@JoeLametta JoeLametta mentioned this issue Sep 3, 2018
Closed
@JoeLametta JoeLametta added Support Questions that needs answering with no code changes needed or that only require a one time change Accepted Accepted issue on our roadmap Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Feature New feature Priority: low Low priority Needed: patch A pull request is required and removed idea Support Questions that needs answering with no code changes needed or that only require a one time change labels Nov 12, 2018
@JoeLametta JoeLametta added this to the 2.0 milestone Nov 13, 2018
@Freso
Copy link
Member Author

Freso commented Feb 13, 2019

AFAICT with the output we're already getting we should be able to save Release Group and Track MBIDs in addition to the rest of what we're currently saving. I'll try and make a PR.

@Freso Freso assigned Freso and unassigned JoeLametta Feb 13, 2019
@JoeLametta
Copy link
Collaborator

@Freso A bit unrelated but I'd like to fix this warning before tagging the next release:

INFO:musicbrainzngs:in <ws2:release-group>, uncaught attribute type-id

@Freso
Copy link
Member Author

Freso commented Feb 13, 2019

@JoeLametta Is there an issue for that? If not, you should make an issue for that and label it accordingly and maybe ping me in that instead of in unrelated issues. ;) (Or you could come on IRC and point it out!)

Freso added a commit that referenced this issue Feb 13, 2019
@Freso
Refresh MusicBrainz JSON dumps used for testing
a08bbee 
Some of these dumps predate when MusicBrainz had (re)introduced track
MBIDs, so some tests for the code for issue #200 would fail since the
JSON dumps didn't contain those IDs.

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@Freso Freso mentioned this issue Feb 13, 2019
Merged
@Freso Freso mentioned this issue Feb 13, 2019
Merged
3 tasks
@JoeLametta
Copy link
Collaborator

@JoeLametta

I know, was in a hurry (sorry).

Freso added a commit that referenced this issue Feb 13, 2019
@Freso
Add Track MBIDs to ripped files
41b1b1f 
See https://musicbrainz.org/doc/Track

First part of #200

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso added a commit that referenced this issue Feb 13, 2019
@Freso
Add Release Group MBIDs to ripped files
c963b01 
See https://musicbrainz.org/doc/Release_Group

Second part of #200

(MusicBrainz JSON test data dumps needed to be refreshed due to the
new `includes` in the MusicBrainz web service call.)

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso added a commit that referenced this issue Feb 13, 2019
@Freso
Add Work MBIDs to ripped files
364f024 
See https://musicbrainz.org/doc/Work

Third and final and thus closes #200

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@JoeLametta JoeLametta removed Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) Needed: patch A pull request is required labels Feb 13, 2019
@JoeLametta JoeLametta removed this from the 2.0 milestone Feb 13, 2019
@JoeLametta JoeLametta added this to the 1.0 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freso Freso

Labels
Accepted Accepted issue on our roadmap Feature New feature Priority: low Low priority
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Freso @JoeLametta