Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Dockerfile for performance #305

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 5, 2018

it's better to install/build whipper at the end of the Dockerfile,
because it will allow us to cache costly operations like locale-gen
while rebuilding with new source changes.

it's better to install/build whipper at the end of the Dockerfile,
because it will allow us to cache costly operations like locale-gen
while rebuilding with new source changes.
@JoeLametta
Copy link
Collaborator

Thanks for the pull request!
I'm not a Docker user but I think cURL can be replaced with wget too (the latter is probably leaner on dependencies): does it make sense?

@anarcat
Copy link
Contributor Author

anarcat commented Oct 6, 2018 via email

@JoeLametta JoeLametta changed the title reorder Dockerfile for performance Reorder Dockerfile for performance Oct 6, 2018
@JoeLametta JoeLametta merged commit 8b5e8a6 into whipper-team:master Oct 6, 2018
@JoeLametta
Copy link
Collaborator

Merged, thanks!

i trust curl more.

Fine, let's leave it as is.

@anarcat anarcat deleted the docker-order branch October 6, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants