Prevent exception in offset find #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the description of the error.
JoeLametta
force-pushed
the
feature/issue-208-offset-find-exception
branch
from
f789831
to
aa448d7
Compare
Freso
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
I'd personally prefer if the two distinct changes were done as separate commits, but other than that the PR looks good at a glance.
Whipper offset find needs a (remote) matching AccurateRip entry to perform its task and confirm the drive offset: if none is found, return early to prevent exception. Fixes #208.
JoeLametta
force-pushed
the
feature/issue-208-offset-find-exception
branch
from
aa448d7
to
09c3e47
Compare
Done, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whipper offset find needs a (remote) matching AccurateRip entry to perform its task and confirm the drive offset: if none is found, return early to prevent exception.
I've also converted a print statement into a logger warning with a better textual description of the issue.
Fixes #208.