Clean up MusicBrainz nomenclature #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freso
commented
Feb 13, 2019
In general, "albums" in everyday usage is what on MusicBrainz would be considered a release group[1] while as far as I can tell, every single instance of it being used in whipper is referring to a single "edition" of an album, which is what would be called a "release" in MusicBrainz terminology[2]. [1] https://musicbrainz.org/doc/Release_Group [2] https://musicbrainz.org/doc/Release Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso
force-pushed
the
task/cleanup-musicbrainz-nomenclature
branch
from
9389131
to
75c5646
Compare
For historical reasons there is some confusion between Tracks[1] and Recordings[2] in MusicBrainz. Essentially what should be saved to `MUSICBRAINZ_TRACKID` is the Recording MBID—which is what whipper is correctly doing, but the value storing this value was called `mbidTrack` rather than `mbidRecording`, which could potentially cause confusion. [1] https://musicbrainz.org/doc/Track [2] https://musicbrainz.org/doc/Recording Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso
changed the title
|
Thanks for the cleanup and the detailed descriptions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of commits for cleaning up various internal (e.g., variable names) and external uses of terms fetched from MusicBrainz that do not match up with what MusicBrainz calls the same concepts. This is mostly to make the code a bit clearer for someone familiar with MusicBrainz, but also to clear up some inconsistencies—e.g., you would have "%A: album artist" but "%y: release year" before, even though they're both referring to an MB Release "object".
See explanations for changes in individual commits.