WIP: Remove unused arguments for program.cdrdao.ReadTOCTask()

[Freso]

The one place the class is currently instanced, neither fast_toc nor toc_path is used, so there's hardly any reason to keep those around.

[JoeLametta]

neither fast_toc nor toc_path is used

That seems to be an error (not what you've found, I mean the current state): fast_toc should be used. Right now getFastToc() executes cdrdao without the fast-toc switch, in the same way as getTable().

I've also found this:

whipper/whipper/common/program.py

Lines 107 to 119 in 6abd120

	def getTable(self, runner, cddbdiscid, mbdiscid, device, offset,
	toc_path):
	"""
	Retrieve the Table from the drive.
	@rtype: L{table.Table}
	"""
	itable = None
	tdict = {}
	t = cdrdao.ReadTOCTask(device)
	t.description = "Reading table"
	t.toc_path = toc_path

toc_path seems to be set but without being passed as an argument? (is that a wise choice?)

[Freso]

fast_toc should be used.

Why? I've noted before that e.g., ISRC gathering becomes unreliable when using --fast-toc and @jtl999 also made a comment that they'd prefer not to use it.

toc_path seems to be set but without being passed as an argument

Ah, I did miss that I'll update this to no longer include the toc_path. Not using it as an argument is okay, I guess, except it makes it harder to grok instances of the class (like I did), since it won't show in a git grep for the class name.

[JoeLametta]

Why? I've noted before that e.g., ISRC gathering becomes unreliable when using --fast-toc and @jtl999 also made a comment that they'd prefer not to use it.

Didn't remember that. Anyway we're still performing the slow cdrdao read two times in a row. Maybe we can completely remove the getFastToc function and use only getTable: that will require updating both whipper/common/program.py and whipper/command/cd.py.

[mtdcr]

Unless there's a compelling reason against it, I'm going to submit a PR to make getFastToc() fast again. The result of getFastToc() only get's used to compute IDs for CDDB and MusicBrainz (and thus also an index into whipper's table cache). No ISRC data will ever get used from it.

My PR will also include a patch to convert the last other uses of ittoc to itable to let the limited purpose of getFastToc() appear more clearly.

[JoeLametta]

Closed because of #417 & 2e966a4.