Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MusicBrainz Release URL in log output #382

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

Freso
Copy link
Member

@Freso Freso commented Mar 16, 2019

This also passes all metadata to the result object, giving loggers a lot more (release) metadata to work with, in case custom, “3rd party” loggers (or even ourselves in the future!) want to do something more fancy or expansive with the metadata in the log file.

Fixes #381

@MerlijnWajer
Copy link
Collaborator

You might want to add metadata here https://github.com/whipper-team/whipper/blob/master/whipper/result/result.py#L67 to RipResult.

@Freso
Copy link
Member Author

Freso commented Mar 16, 2019

@MerlijnWajer But there's nothing there getting the metadata? self.program.result in cd.py is an instance of RipResult. cd.CD_.do() is the method that's responsible for populating the RipResult class instance(s) with (meta)data currently.

This also passes *all* metadata to the `result` object, giving loggers a
lot more (release) metadata to work with, in case custom, “3rd party”
loggers (or even ourselves in the future!) want to do something more
fancy or expansive with the metadata in the log file.

Fixes #381

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@Freso Freso force-pushed the feature/issue-381-add-release-mbid-to-log branch from dd3d59d to a758ea5 Compare March 16, 2019 20:30
@Freso
Copy link
Member Author

Freso commented Mar 16, 2019

@MerlijnWajer Done. :)

@Freso
Copy link
Member Author

Freso commented Mar 16, 2019

Sample .log output as of commit a758ea5:

Log created by: whipper 0.7.4.dev52+ga758ea5 (internal logger)
Log creation date: 2019-03-16T21:03:32Z

Ripping phase information:
  Drive: TSSTcorpCDDVDW SN-208BB  (revision SB02)
  Extraction engine: cdparanoia III 10.2 libcdio 2.0.0 x86_64-pc-linux-gnu
  Defeat audio cache: Yes
  Read offset correction: +6
  Overread into lead-out: No
  Gap detection: cdrdao 1.2.4
  CD-R detected: No

CD metadata:
  Release: Ginuwine - Pony
  CDDB Disc ID: 2d047f04
  MusicBrainz Disc ID: TX6lKZ481BHv1ZW6pd6007j6OY4-
  MusicBrainz lookup url: https://musicbrainz.org/cdtoc/attach?toc=1+4+86497+150+24687+47627+68002&tracks=4&id=TX6lKZ481BHv1ZW6pd6007j6OY4-
  MusicBrainz Release url: https://musicbrainz.org/release/84e4ddc3-92fd-49d5-b15d-3be7f85c85ab

TOC:
  1:
    Start: 00:00:00
    Length: 05:27:12
    Start sector: 0
    End sector: 24536

  2:
    Start: 05:27:12
    Length: 05:05:65
    Start sector: 24537
    End sector: 47476

  3:
    Start: 10:33:02
    Length: 04:31:50
    Start sector: 47477
    End sector: 67851

  4:
    Start: 15:04:52
    Length: 04:06:45
    Start sector: 67852
    End sector: 86346

Tracks:
  1:
    Filename: /home/freso/tmp/Ginuwine - Pony (1996) [FLAC]/01. Ginuwine - Pony _album version_.flac
    Peak level: 0.901611
    Pre-emphasis: No
    Extraction speed: 2.0 X
    Extraction quality: 100.00 %
    Test CRC: 255B4AFF
    Copy CRC: 255B4AFF
    AccurateRip v1:
      Result: Found, exact match
      Confidence: 26
      Local CRC: BE390E39
      Remote CRC: BE390E39
    AccurateRip v2:
      Result: Found, exact match
      Confidence: 34
      Local CRC: 7A03BC55
      Remote CRC: 7A03BC55
    Status: Copy OK

  2:
    Filename: /home/freso/tmp/Ginuwine - Pony (1996) [FLAC]/02. Ginuwine - Pony _Ride It mix_.flac
    Pre-gap length: 00:01:65
    Peak level: 0.988556
    Pre-emphasis: No
    Extraction speed: 2.2 X
    Extraction quality: 100.00 %
    Test CRC: 59B050EA
    Copy CRC: 59B050EA
    AccurateRip v1:
      Result: Found, exact match
      Confidence: 24
      Local CRC: 9E9AABC0
      Remote CRC: 9E9AABC0
    AccurateRip v2:
      Result: Found, exact match
      Confidence: 33
      Local CRC: 79008752
      Remote CRC: 79008752
    Status: Copy OK

  3:
    Filename: /home/freso/tmp/Ginuwine - Pony (1996) [FLAC]/03. Ginuwine - Pony _Black Market radio mix_.flac
    Pre-gap length: 00:01:07
    Peak level: 0.988556
    Pre-emphasis: No
    Extraction speed: 2.4 X
    Extraction quality: 100.00 %
    Test CRC: 3ECA8CF5
    Copy CRC: 3ECA8CF5
    AccurateRip v1:
      Result: Found, exact match
      Confidence: 24
      Local CRC: E6B184BE
      Remote CRC: E6B184BE
    AccurateRip v2:
      Result: Found, exact match
      Confidence: 34
      Local CRC: B1D6AEFE
      Remote CRC: B1D6AEFE
    Status: Copy OK

  4:
    Filename: /home/freso/tmp/Ginuwine - Pony (1996) [FLAC]/04. Ginuwine - Hello.flac
    Pre-gap length: 00:01:05
    Peak level: 0.966064
    Pre-emphasis: No
    Extraction speed: 2.7 X
    Extraction quality: 100.00 %
    Test CRC: 979CAC27
    Copy CRC: 979CAC27
    AccurateRip v1:
      Result: Found, exact match
      Confidence: 24
      Local CRC: D44CB1C3
      Remote CRC: D44CB1C3
    AccurateRip v2:
      Result: Found, exact match
      Confidence: 33
      Local CRC: 796B0878
      Remote CRC: 796B0878
    Status: Copy OK

Conclusive status report:
  AccurateRip summary: All tracks accurately ripped
  Health status: No errors occurred
  EOF: End of status report

SHA-256 hash: 3B67846779C1746F99C32B62D1B50E004F09B4F82B48F4BE550CCEF18305EDD6

@Freso Freso added this to the 0.8.0 milestone Mar 17, 2019
Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@JoeLametta JoeLametta merged commit 135cc9c into develop Mar 18, 2019
@JoeLametta JoeLametta deleted the feature/issue-381-add-release-mbid-to-log branch March 18, 2019 11:15
@JoeLametta
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants