Allow customization of maximum rip attempts value #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABCbum
force-pushed
the
customize-max-tries
branch
from
51ee36d
to
2d434d8
Compare
|
I've pushed a commit. Don't know if gracefully handling non |
JoeLametta
approved these changes
Jan 28, 2020
JoeLametta
force-pushed
the
customize-max-tries
branch
from
b9cb0d6
to
c1e9b4c
Compare
|
I think it should be good after squashing it into one commit since forcing it to int works for cases such as 001 becomes 1. Thanks (. ❛ ᴗ ❛.) |
Add new `--max-retries` argument to allow users to specify maximum number of attempts to try before giving up ripping a track. This value defaults to `5` while `0` means infinity. Possible errors (negative number, string, etc) are also handled. Co-authored-by: JoeLametta <JoeLametta@users.noreply.github.com> Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com> Signed-off-by: ABCbum <kimlong221002@gmail.com>
JoeLametta
force-pushed
the
customize-max-tries
branch
from
c1e9b4c
to
9db3aa9
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #349
Solution
Add new
--max-retriesargument to allow users to specify maximum numberof attempts to try before giving up ripping a track. This value defaults to
5while0means infinity.Possible errors (negative number, string, etc) are also handled.