Fix storing messages #111
Merged
Fix storing messages #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, message timestamps are encrypted when storing. This does not work when retrieving messages before a timestamp (and I think currently does not work when getting/deleting messages in general). This PR fixes this by just removing the encryption. Before this PR should actually be merged, it should maybe be discussed if removing the encryption is actually a good thing to do, but as far as I see it is the only thing possible except for every time we look for messages of a thread, decrypt all message keys and manually sort and iterate them.
gferon
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, message timestamps are encrypted when storing. This does not work when retrieving messages before a timestamp (and I think currently does not work when getting/deleting messages in general). This PR fixes this by just removing the encryption.
Before this PR should actually be merged, it should maybe be discussed if removing the encryption is actually a good thing to do, but as far as I see it is the only thing possible except for every time we look for messages of a thread, decrypt all message keys and manually sort and iterate them.