Fix storing outgoing messages #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c5f23d4 broke storing outgoing messages by not setting the message thread and instead calculating it from the message, which can not differentiate between incoming and outgoing messages. This sets the thread for outgoing messages like done before. This commit also stores call messages as I think these should also be shown in the chat-history and should therefore be stored. This is debatable though as I have no idea how Signal is handling that.
|
Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c5f23d4 broke storing outgoing messages by not setting the message thread and instead calculating it from the message, which can not differentiate between incoming and outgoing messages. This sets the thread for outgoing messages like done before.
This commit also stores call messages as I think these should also be shown in the chat-history and should therefore be stored. This is debatable though as I have no idea how Signal is handling that.