Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send messages as unidentified sender #159

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Send messages as unidentified sender #159

merged 3 commits into from
Apr 19, 2023

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Apr 18, 2023

TODO:

  • Store profile keys somewhere

@gferon
Copy link
Collaborator Author

gferon commented Apr 18, 2023

@Schmiddiii would you mind giving this a test run? Just make sure to set unidentified to true when calling Manager::send_message.

@Schmiddiii
Copy link
Contributor

  • 1-to-1 seems to work fine (I sent a message to you).
  • note-to-self errors with "Websocket closing while sending request"
  • Groups do not yet have unidentified sending?
  • When should a client use unidentified sending and when not? Should this maybe be determined inside presage without that public unidentified-parameter?

@gferon
Copy link
Collaborator Author

gferon commented Apr 19, 2023

@Schmiddiii this was WIP, and all of your concerns are now addressed. I'll go ahead and merge this right away 🚀

@gferon gferon added this to the 0.5.1 milestone Apr 19, 2023
@gferon gferon enabled auto-merge (squash) April 19, 2023 20:45
@gferon gferon merged commit b9d57d6 into main Apr 19, 2023
@gferon gferon deleted the sealed-sender branch April 19, 2023 20:46
@gferon gferon restored the sealed-sender branch April 19, 2023 20:47
@gferon gferon deleted the sealed-sender branch April 19, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants