-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional system notifications in example CLI #85
Conversation
Question, there is no easier way to get my uuid, because |
I found the |
examples/cli.rs
Outdated
match metadata.sender.uuid { | ||
Some(uuid) => { | ||
println!("uuid: {:?}", uuid); | ||
for contact in manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should find a way to put this inside of Manager
since IMO this is what presage
is about. I'm fine merging this as-is for now, though. I'll try to see if there's a way to include it inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but it should be optional, because maybe it's used on a headless server without the need for notifications. I can resolve the fmt and build problems
I have to test if typing messages etc. also trigger a notification. And we should find a way to toggle the notifcations per session. |
I ended up rewriting the message receiving part of the CLI to format messages in a much prettier fashion. Thanks for the PR! |
This pr adds notifications via a generic rust library